fix(view): 무한 스크롤을 위한 FakeIDEAdapter 개선#1008
Merged
SingTheCode merged 2 commits intoOct 25, 2025
Merged
Conversation
- Change FakeIDEAdapter to return AnalyzedDataPayload structure instead of ClusterNode[] array - Add missing fields: isLastPage, nextCommitId, isLoadMore, isPRSuccess - Ensure consistency between development and production environments Fixes #1007 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add pagination logic to FakeIDEAdapter to simulate real data fetching for infinite scrolling. - Implement page tracking using currentPage and PAGE_SIZE to slice and return partial data. - Ensure FakeIDEAdapter is a singleton to maintain pagination state across requests. - Update message handling to support 'load more' functionality based on lastCommitId. Related to #1007
nxnaxx
approved these changes
Oct 20, 2025
Contributor
nxnaxx
left a comment
nxnaxx
left a comment
There was a problem hiding this comment.
개발 모드 에러 발생해서 어떻게 해야하나 했는데,
빠른 수정 감사합니다!👍🏻👍🏻
chae-dahee
approved these changes
Oct 20, 2025
Contributor
chae-dahee
left a comment
chae-dahee
left a comment
There was a problem hiding this comment.
ㅜㅜ제가 놓친 부분 더블체크 해주셔서 정말 감사합니다!! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 목적
FakeIDEAdapter의 데이터 페이로드 구조를 실제VSCodeIDEAdapter와 일치시킵니다.FakeIDEAdapter에 페이지네이션 기능을 구현합니다.📋 주요 변경사항
FakeIDEAdapter가 반환하는 데이터에isLastPage,nextCommitId,isLoadMore필드를 추가하여 실제 어댑터와 구조를 일치시켰습니다.FakeIDEAdapter에 페이지 상태를 관리하는 로직을 추가하여, 실제 API처럼 데이터를 나누어 제공하도록 수정했습니다.FakeIDEAdapter를 싱글톤으로 등록하여 페이지 상태가 요청 간에 유지되도록 보장합니다.📊 영향 범위
packages/view/src/ide/FakeIDEAdapter.tspackages/view/src/index.tsx✅ 체크리스트
🔗 관련 이슈