fix(scale-up): return partial runner creation results#5220
Open
edersonbrilhante wants to merge 5 commits into
Open
fix(scale-up): return partial runner creation results#5220edersonbrilhante wants to merge 5 commits into
edersonbrilhante wants to merge 5 commits into
Conversation
edersonbrilhante
marked this pull request as draft
July 22, 2026 21:40
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This was referenced Jul 22, 2026
edersonbrilhante
marked this pull request as ready for review
July 23, 2026 11:16
npalm
reviewed
Jul 24, 2026
| @@ -58,6 +57,12 @@ export async function scaleUpHandler(event: SQSEvent, context: Context): Promise | |||
| try { | |||
| const rejectedMessageIds = await scaleUp(sqsMessages); | |||
Member
There was a problem hiding this comment.
would rename here the const name, since the return value is now the result. So a more logical name woudl be createRunnerResult
Contributor
Author
There was a problem hiding this comment.
scaleUp still returning the same rejectedMessageIds. That is a list of messageId that will send to ReportBatchItemFailures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor runner creation to return structured partial-success results instead of throwing
ScaleError.retryableErrorCountandnonRetryableErrorCount.ScaleErrorimplementation and handler logic.Test Plan
TBD
Related Issues
None.