Skip to content

Conversation

@smockle
Copy link
Collaborator

@smockle smockle commented Oct 30, 2025

Fixes https://github.com/github/continuous-ai-for-accessibility/issues/79 (Hubber access only)

This PR logs the URL actually open in the Playwright-driven browser, revealing whether the scanner is repeatedly scanning a login or 404 page instead of the intended page.

@smockle smockle requested a review from a team as a code owner October 30, 2025 12:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates logging messages in the accessibility scanning action to provide more precise information about the scanning process. The changes clarify the distinction between preparing to scan a URL and the actual scanning phase.

  • Updated the initial log message to indicate preparation rather than active scanning
  • Added a new log message that outputs the actual URL being scanned after navigation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/actions/find/src/index.ts Changed log message from "Scanning" to "Preparing to scan" to reflect the pre-scan state
.github/actions/find/src/findForUrl.ts Added console.log statement to output the actual URL being scanned after page navigation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@smockle smockle enabled auto-merge October 30, 2025 14:51
@smockle smockle merged commit 71f1a31 into main Oct 30, 2025
11 of 12 checks passed
@smockle smockle deleted the smockle/log-actual-visited-url branch October 30, 2025 14:53
@smockle smockle mentioned this pull request Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants