Skip to content

Conversation

@smockle
Copy link
Collaborator

@smockle smockle commented Oct 30, 2025

Fixes https://github.com/github/continuous-ai-for-accessibility/issues/80 (Hubber access only)

This PR updates the “Auth” sub-action to find username fields labelled “user name” or “username”.

Before https://github.com/github/accessibility-sandbox/actions/runs/18947551717/job/54103069255 (Hubber access only):

Starting 'auth' action
Navigating to login page
Checking for login form
No login form detected
Finished 'auth' action

After https://github.com/github/accessibility-sandbox/actions/runs/18947605567/job/54103255182 (Hubber access only):

Starting 'auth' action
Navigating to login page
Checking for login form
Filling username
Filling password
Logging in
Finished 'auth' action

@smockle smockle requested a review from a team as a code owner October 30, 2025 16:16
@smockle smockle enabled auto-merge October 30, 2025 16:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the username field selector in the authentication action to handle variations in spacing within the label text. The regular expression now matches both "username" and "user name" (with optional space).

Key Changes:

  • Modified the username field selector regex to account for optional whitespace

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@smockle smockle changed the title fix: Find username fields labelled 'user name' fix(Auth): Find username fields labelled 'user name' Oct 30, 2025
@smockle smockle merged commit ab56219 into main Oct 30, 2025
11 checks passed
@smockle smockle deleted the smockle/find-user-space-name-field branch October 30, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants