Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHSA-vrmr-f2qh-3hhf] Improper use of cryptographic key in wal-g #5002

Conversation

andrewpollock
Copy link

Updates

  • Affected products

Comments
Fix versions for SEMVER compliance

@github-actions github-actions bot changed the base branch from main to andrewpollock/advisory-improvement-5002 November 11, 2024 06:17
@shelbyc
Copy link
Contributor

shelbyc commented Nov 12, 2024

Hi @andrewpollock, as in #5001, we set the vulnerable version range to < 1.1 because there is no version 1.1.0 on https://github.com/wal-g/wal-g or on https://pkg.go.dev/github.com/wal-g/wal-g. The fix commit is tagged with 1.1 and the release notes for version 1.1 mention the fix, so we're confident that < 1.1 is the correct VVR and 1.1 is the correct patched version.

@andrewpollock
Copy link
Author

Hey @shelbyc 👋

Oh, interesting. I hadn't properly appreciated until now that this record is published with an ECOSYSTEM range type (so this version is fine as is) but OSV.dev is coercing all records with ranges for the Go ecosystem to SEMVER, which is where this becomes problematic.

Not your problem 😸

Sorry for the noise!

@github-actions github-actions bot deleted the andrewpollock-GHSA-vrmr-f2qh-3hhf branch November 13, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants