[GHSA-cvvx-r33m-v7pq] Improper Input Validation in Apache Struts #6306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates a GitHub Security Advisory for CVE-2015-0899 to correctly specify affected Apache Struts packages by separating the version ranges for two different Maven coordinates that were used for different Struts versions.
- Updates the modified timestamp to reflect recent changes
- Splits affected package definitions to handle different Maven groupId/artifactId patterns
- Adds explicit coverage for the legacy
struts:strutspackage coordinate
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "type": "ECOSYSTEM", | ||
| "events": [ | ||
| { | ||
| "introduced": "1.1" |
There was a problem hiding this comment.
The new struts:struts package entry is missing an upper bound version range. According to the PR description, struts 1.1 - 1.2.9 uses the struts:struts coordinate, so this range should include a last_affected field set to 1.2.9 to properly define the affected version range.
Suggested change
| "introduced": "1.1" | |
| "introduced": "1.1" | |
| }, | |
| { | |
| "last_affected": "1.2.9" |
Copilot uses AI. Check for mistakes.
github-actions
bot
changed the base branch from
main
to
ryanmurf/advisory-improvement-6306
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Comments
struts 1.1 - 1.2.9 is under the groupId struts and the artifactId is struts.
struts >=1.3 the groupId is org.apache.struts and artifactId is struts-core.