Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the upload-sarif testing by replacing the basic upload-quality-sarif test with a more comprehensive upload-sarif test that covers multiple analysis kinds. The changes also refactor the uploadPayload function to accept an analysis configuration object instead of just a target parameter.
- Expands test coverage for upload-sarif functionality across different analysis kinds (code-scanning, code-quality, and combined scenarios)
- Refactors the uploadPayload function signature to use analysis configuration objects for better payload file naming in test mode
- Updates test verification scripts to use the new analysis-specific payload file naming convention
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/upload-lib.ts | Changes uploadPayload function signature and updates payload file naming in test mode |
| pr-checks/checks/upload-sarif.yml | New comprehensive test covering multiple upload-sarif scenarios |
| pr-checks/checks/upload-quality-sarif.yml | Removes old basic upload-quality-sarif test |
| pr-checks/checks/with-checkout-path.yml | Updates payload file reference to use new naming convention |
| lib/*.js files | Generated JavaScript code reflecting the TypeScript changes |
| .github/workflows/*.yml | Generated workflow files from the updated test templates |
henrymercer
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames the
upload-quality-sarifcheck toupload-sarifand covers more cases.Risk assessment
For internal use only. Please select the risk level of this change:
Merge / deployment checklist