Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR applies a linting rule to enforce the use of optional chaining (?.) instead of manual null/undefined checks combined with property access. The changes simplify conditional expressions by replacing patterns like foo && foo.bar and foo === null || foo.bar with the more concise foo?.bar syntax.
Key changes:
- Enabled the
@typescript-eslint/prefer-optional-chainESLint rule - Refactored conditional expressions throughout the codebase to use optional chaining
- Updated both TypeScript source files and their compiled JavaScript outputs
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eslint.config.mjs | Enabled the @typescript-eslint/prefer-optional-chain linting rule |
| src/workflow.ts | Simplified undefined check with optional chaining for input validation |
| src/tar.ts | Applied optional chaining to regex match result checks |
| src/start-proxy-action-post.ts | Refactored config debug mode check using optional chaining |
| src/setup-codeql.ts | Simplified null check with optional chaining for match result |
| src/config/db-config.ts | Consolidated nested property checks into single optional chaining expression |
| src/config-utils.ts | Applied optional chaining to regex match groups check |
| lib/*.js | Compiled JavaScript output reflecting the TypeScript changes above |
mbg
approved these changes
Oct 22, 2025
Member
mbg
left a comment
There was a problem hiding this comment.
Not a huge fan of the ?.[i] case, but otherwise I am in favour of this change, so I'll approve.
This was referenced Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚲🏠
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
analysis-kinds: code-scanning).analysis-kinds: code-quality).upload-sarif).How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Merge / deployment checklist