Rust: Vendor build files for 3rdparty dependencies. #17976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been observing some performance issues using crate_universe on CI. Therefore, we're moving to vendor the auto-generated BUILD files in our repository. This should provide a nice speed boost, while getting rid of the complexity of the "rust cache" job we've been using when we had a lot of git dependencies. This PR includes a vendor script, and I'll put up a CI job internally that runs that vendor script on Cargo.toml and Cargo.lock changes, to check that the vendored files are in sync.
criemen
force-pushed
the
criemen/rust-3rdparty
branch
from
73da749 to
a66f820
Compare
tausbn
approved these changes
Nov 13, 2024
| @@ -24,6 +24,7 @@ include = [ | |||
| [lib] | |||
| path = "bindings/rust/lib.rs" | |||
|
|
|||
| ## When updating these dependencies, run `misc/bazel/3rdparty/update_cargo_deps.sh` | |||
Contributor
There was a problem hiding this comment.
This one gets a double comment! I assume there's no semantic significance. 🙂
Collaborator
Author
There was a problem hiding this comment.
Does it? I tried to add the comment to every Cargo.toml file that contributes to an extractor build, with the exception of ql-for-ql, which we don't build with bazel.
Contributor
There was a problem hiding this comment.
I meant compared to the other Cargo.toml file (edit: the one for plain tsg-python, not the tsp sub-package), where the added line starts with a single comment character. Sorry for the confusing wording.
Collaborator
Author
There was a problem hiding this comment.
Ah, double shebang! Yeah that wasn't intentional, but shouldn't change anything either.
criemen
changed the title
oscarsj
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been observing some performance issues using
crate_universeon CI. Therefore, we're moving to vendor the auto-generated BUILD files in our repository. This should provide a nice speed boost, while getting rid of the complexity of the "rust cache" job we've been using when we had a lot of git dependencies.This PR includes a vendor script, and I'll put up a CI job internally that runs that vendor script on
Cargo.tomlandCargo.lockchanges, to check that the vendored files are in sync.For rust on linux this saves >1min on CI, macos also ca. 1min, Windows 3min.
I assume similar time savings hold for Ruby, and a bit less for python.