actions: Add some missing permissions #19357
Open
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adjust the comments for actions that do not need permissions
There was a problem hiding this comment.
Pull Request Overview
This PR adds explicit permission entries for the actions/add-to-project action and adjusts comments for download, upload, and cache actions to indicate that no permissions are needed.
- Added four permission entries for actions/add-to-project
- Updated TODO comments to explicit "No permissions needed" comments for actions/download-artifact, actions/upload-artifact, and actions/cache
adityasharad
previously approved these changes
Apr 23, 2025
|
Oh tests need updating. |
adityasharad
previously approved these changes
Apr 23, 2025
|
Change note under minor analysis improvements? |
Ah right, we just shipped so we need a new change note. |
adityasharad
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adjust the comments for actions that do not need permissions
MIssing permission discovered by comparing with https://github.com/github/codeql/pull/18517/files#diff-aa70ee2d09e3b6c4a50a963ad4791be3a20e376bfd2693085edede530d72608f.