JS: Tolerate trailing commas in JSON objects #19393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the JSON parser logic so that trailing commas in JSON objects are tolerated rather than triggering an error.
- Removed the check that raised an error for trailing commas in JSON objects.
- Aligns the extractor behavior with updated expectations for JSON object formatting.
Files not reviewed (2)
- javascript/extractor/tests/json/input/object-trailing-comma.json: Language not supported
- javascript/extractor/tests/json/output/trap/object-trailing-comma.json.trap: Language not supported
Comments suppressed due to low confidence (1)
javascript/extractor/src/com/semmle/js/parser/JSONParser.java:154
- It would be helpful to add a comment explaining that trailing commas in JSON objects are intentionally allowed per the updated requirements, to aid future maintainability.
if (!needsComma) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stops the extractor from complaining about trailing commas in JSON objects.
When preparing #19267 I somehow convinced myself that this was already working for JSON objects, but it has the exact same issue.