C++: Update expected test results after extractor changes #19837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jketema
added
the
depends on internal PR
There was a problem hiding this comment.
Pull Request Overview
Updates expected test outputs and query definitions to align with recent extractor changes.
- Adjusted test comments in
printf1.hto reflect new detection status for%zuformat arguments. - Updated
.expectedfiles forWrongTypeFormatArguments, IR, and AST outputs to use__builtin_va_listinstead of__va_list_tag[1]. - Refined
usertypes.qlwith grouped conditions and file-existence filter.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
printf1.h (Microsoft_no_wchar & Microsoft) |
Changed inline comments to mark two format checks as failures. |
WrongTypeFormatArguments.expected (both dirs) |
Added new expected diagnostics for ul and sst. |
raw_ir.expected, aliased_ir.expected, PrintAST.expected |
Replaced __va_list_tag[1] with __builtin_va_list. |
usertypes.ql |
Wrapped OR conditions in parentheses and added exists(t.getFile()) filter. |
Comments suppressed due to low confidence (1)
cpp/ql/test/library-tests/floats/float128/usertypes.ql:5
- [nitpick] Indentation of the grouped conditions block is inconsistent. Consider aligning the inner lines at the same indentation level to improve readability.
(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See internal PR for details.