Rust: Handle Deref trait in type inference and data flow
#20987
+2,041
−1,340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
265
to
296
| /** | ||
| * Index assignments like `a[i] = rhs` are treated as `*a.index_mut(i) = rhs`, | ||
| * so they should in principle be handled by `referenceAssignment`. | ||
| * | ||
| * However, this would require support for [generalized reverse flow][1], which | ||
| * is not yet implemented, so instead we simulate reverse flow where it would | ||
| * have applied via the model for `<_ as core::ops::index::IndexMut>::index_mut`. | ||
| * | ||
| * The same is the case for compound assignments like `a[i] += rhs`, which are | ||
| * treated as `(*a.index_mut(i)).add_assign(rhs)`. | ||
| * | ||
| * [1]: https://github.com/github/codeql/pull/18109 | ||
| */ |
Check warning
Code scanning / CodeQL
Predicate QLDoc style Warning
hvitved
force-pushed
the
rust/type-inference-deref-trait
branch
3 times, most recently
from
baba061 to
5dda9be
Compare
hvitved
force-pushed
the
rust/type-inference-deref-trait
branch
2 times, most recently
from
eb1db27 to
e269016
Compare
| pragma[nomagic] | ||
| Type getACandidateReceiverTypeAtSubstituteLookupTraits( | ||
| string derefChain, boolean borrow, TypePath path | ||
| Type getANonPseudoCandidateReceiverTypeAt( |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
hvitved
force-pushed
the
rust/type-inference-deref-trait
branch
from
8266451 to
14037e4
Compare
hvitved
force-pushed
the
rust/type-inference-deref-trait
branch
from
14037e4 to
0c7b1d0
Compare
| ) | ||
| ) | ||
| } | ||
|
|
Check warning
Code scanning / CodeQL
Omittable 'exists' variable Warning
hvitved
force-pushed
the
rust/type-inference-deref-trait
branch
2 times, most recently
from
7880183 to
be3a16a
Compare
hvitved
force-pushed
the
rust/type-inference-deref-trait
branch
6 times, most recently
from
cc413c1 to
adcbfc8
Compare
| string toString() { | ||
| result = this.asCall().toString() | ||
| or | ||
| exists(AstNode n, DerefChain derefChain, int i, Function target | |
Check warning
Code scanning / CodeQL
Omittable 'exists' variable Warning
hvitved
force-pushed
the
rust/type-inference-deref-trait
branch
from
dd62164 to
dc0c45b
Compare
hvitved
force-pushed
the
rust/type-inference-deref-trait
branch
4 times, most recently
from
f3bad27 to
c23d528
Compare
hvitved
changed the title
Deref trait in type inferenceDeref trait in type inference and data flow
hvitved
force-pushed
the
rust/type-inference-deref-trait
branch
from
c23d528 to
76ad749
Compare
Before
```
Pipeline standard for AccessAfterLifetimeExtensions::AccessAfterLifetime::mayEncloseOnStack/2#3cdefece#bf@61cb32j5 was evaluated in 30 iterations totaling 44856ms (delta sizes total: 241646328).
241404616 ~1% {2} r1 = SCAN `AccessAfterLifetimeExtensions::AccessAfterLifetime::mayEncloseOnStack/2#3cdefece#bf#prev_delta` OUTPUT In.1, In.0
7379161442 ~1080% {2} | JOIN WITH `_AstNode::AstNode.getEnclosingBlock/0#5c38e65a_AstNode::AstNode.getEnclosingCallable/0#5a548913_Bloc__#join_rhs` ON FIRST 1 OUTPUT Lhs.1, Rhs.1
333897324 ~40% {2} | AND NOT `AccessAfterLifetimeExtensions::AccessAfterLifetime::mayEncloseOnStack/2#3cdefece#bf#prev`(FIRST 2)
297961888 ~24% {2} | JOIN WITH `project#AccessAfterLifetimeExtensions::AccessAfterLifetime::sourceValueScope/3#d065ba16#2` ON FIRST 1 OUTPUT Lhs.0, Lhs.1
return r1
```
hvitved
force-pushed
the
rust/type-inference-deref-trait
branch
from
76ad749 to
2927d7d
Compare
hvitved
force-pushed
the
rust/type-inference-deref-trait
branch
2 times, most recently
from
60d9084 to
de3a73e
Compare
hvitved
force-pushed
the
rust/type-inference-deref-trait
branch
from
de3a73e to
5c70ae0
Compare
hvitved
force-pushed
the
rust/type-inference-deref-trait
branch
from
5c70ae0 to
20ebba3
Compare
| } | ||
|
|
||
| private class ImplicitDerefOutNode extends ImplicitDerefNode, OutNode { | ||
| private DataFlowCall call; |
Check warning
Code scanning / CodeQL
Dead code Warning
hvitved
force-pushed
the
rust/type-inference-deref-trait
branch
from
7d31e0b to
0c7f4c4
Compare
hvitved
force-pushed
the
rust/type-inference-deref-trait
branch
from
0c7f4c4 to
f63ac8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.