Rust: Add Result::Err to excludeFieldTaintStep
#21114
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Result::Err to the excludeFieldTaintStep configuration to prevent taint from flowing through the error variant of Result types. The rationale is that when a Result value is user-controllable, typically only the Ok branch contains controllable data, not the Err branch. This change reduces false positives in security queries like rust/log-injection and rust/cleartext-logging.
Key Changes
- Added
core::result::Result::Err(0)to theexcludeFieldTaintSteplist
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
paldepind
approved these changes
Jan 7, 2026
Contributor
paldepind
left a comment
paldepind
left a comment
There was a problem hiding this comment.
Seems very reasonable!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation here is that if a
Resultvalue is user-controllable, then it likely means that only theOkbranch is controllable. DCA confirms that we have fewer results forrust/log-injectionandrust/cleartext-logging.