Style guide updates #36455
Style guide updates #36455
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options:
A Hubber will need to deploy your changes internally to review. Table of review linksThe table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
github-actions
bot
added
the
triage
There was a problem hiding this comment.
Hi @hdub-tech, thanks for raising this—I've just left a few small comments for you to address and then we should be good to merge this. Thanks for your interest in our docs and style guide!
content/support/learning-about-github-support/about-github-premium-support.md
Outdated
Show resolved
Hide resolved
content/support/learning-about-github-support/about-github-premium-support.md
Outdated
Show resolved
Hide resolved
subatoi
added
waiting for review
| @@ -60,7 +60,7 @@ Personal Data is collected from you directly, automatically from your device, an | |||
| * Essential Cookies and Similar Tracking Technologies: We use cookies and similar technologies to provide essential functionality like storing settings and recognizing you while using our Services. | |||
| * Non-essential Cookies: Depending on your jurisdiction, we may use online analytics products that use cookies to help us analyze how de-identified users use our Services and to enhance your experience when you use the Services. We may also employ third-party Cookies to gather data for interest-based advertising. In some jurisdictions, we only use non-essential cookies after obtaining your consent. See [this](#what-are-your-cookie-choices-and-controls) section for more details and control options. | |||
| * Email Marketing Interactions: Our emails may have web beacons that offer information on your device type, email client, email reception, opens, and link clicks. | |||
| * Geolocation Information: Depending on the Service's functionality, we collect regional geolocation data | |||
| * Geolocation Information: Depending on the Service's functionality, we collect regional geolocation data. | |||
There was a problem hiding this comment.
I know this is frustrating but let's leave this out of this PR: I'll raise it separately with our Site Policy team
There was a problem hiding this comment.
Ha, understood. It was the one thing that jumped off the page to my eyes and was actually what led me to start the PR 😅 . I will revert this commit momentarily.
There was a problem hiding this comment.
I should have asked @hdub-tech but if you'd prefer to raise it yourself, you can do so here https://github.com/github/site-policy/blob/main/CONTRIBUTING.md
There was a problem hiding this comment.
Oh is there not already an internal issue for it? Either way, I can open a public one for you if you did not already beat me to it.
There was a problem hiding this comment.
I haven't opened one yet; I wanted to give you the option to open one publicly, so you'd get the full credit for it. Either way just let me know here 👍
There was a problem hiding this comment.
Apologies on the delay, I didn't receive a notification for your comment! Here is the issue: https://github.com/github/docs/issues/36556
Inconsistent capitalization and table formatting
- Remove inconsistent periods in list - Remove "etc" per style guide
|
OK @subatoi - I think this addresses all your concerns. LMK if I missed anything. |
There was a problem hiding this comment.
Thanks again, @hdub-tech! I'll get this merged for you now.
Thanks for your interest in our Docs!
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Fixes: Small style issues discovered while reading the various Terms of Service
What's being changed (if available, include any code snippets, screenshots, or gifs):
Punctuation, formatting, and phrasing changes were made to match the Style guide (This is one of the only PRs I have ever opened where I feel like the Files Changed tab should be sufficient to demonstrate changes, without needing extra images, details or a separate issue).
Check off the following: