-
Notifications
You must be signed in to change notification settings - Fork 61.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing subheading level sudo-mode.md #36498
Conversation
Was working on some docs for WordPress VIP about a similar feature and saw that one of the subheading on this page wasn't at the correct level in the hierarchy. This should fix that.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options:
A Hubber will need to deploy your changes internally to review. Table of review linksThe table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ThirdEyeRose, thanks for spotting and fixing that—would you be willing to change line 48, too? I don't think we need it to say "passkey key". Let me know, but either way I'm happy to merge this. Thank you!
Sure can, @subatoi ! Requested change has been made on the PR branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @ThirdEyeRose! I'll get this merged now. Thanks again for your help and interest in our docs ✨
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Was working on some docs for WordPress VIP about a similar feature and saw that one of the subheading on this page wasn't at the correct level in the hierarchy. This should fix that.
Why:
Closes: No issue - just a subheading change
What's being changed (if available, include any code snippets, screenshots, or gifs):
As you can see, the top two headings are H2s whereas the second heading should be an H3 to match the others.
Check off the following: