Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing subheading level sudo-mode.md #36498

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

ThirdEyeRose
Copy link
Contributor

Was working on some docs for WordPress VIP about a similar feature and saw that one of the subheading on this page wasn't at the correct level in the hierarchy. This should fix that.

Why:

Closes: No issue - just a subheading change

What's being changed (if available, include any code snippets, screenshots, or gifs):

image

As you can see, the top two headings are H2s whereas the second heading should be an H3 to match the others.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

Was working on some docs for WordPress VIP about a similar feature and saw that one of the subheading on this page wasn't at the correct level in the hierarchy. This should fix that.
Copy link

welcome bot commented Feb 25, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 25, 2025
Copy link
Contributor

github-actions bot commented Feb 25, 2025

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

⚠️ Warning: Our review server is experiencing latency issues.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on the review server. Changes to the data directory are not included in this table.

Source Review Production What Changed
authentication/keeping-your-account-and-data-secure/sudo-mode.md fpt
ghec
ghes@ 3.16 3.15 3.14 3.13 3.12
fpt
ghec
ghes@ 3.16 3.15 3.14 3.13 3.12

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@subatoi subatoi added content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team labels Feb 26, 2025
subatoi
subatoi previously approved these changes Feb 26, 2025
Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ThirdEyeRose, thanks for spotting and fixing that—would you be willing to change line 48, too? I don't think we need it to say "passkey key". Let me know, but either way I'm happy to merge this. Thank you!

@ThirdEyeRose
Copy link
Contributor Author

Sure can, @subatoi ! Requested change has been made on the PR branch

Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @ThirdEyeRose! I'll get this merged now. Thanks again for your help and interest in our docs ✨

@subatoi subatoi enabled auto-merge February 26, 2025 14:41
@subatoi subatoi added this pull request to the merge queue Feb 26, 2025
Merged via the queue into github:main with commit efc4a14 Feb 26, 2025
45 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team more-information-needed More information is needed to complete review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants