-
Notifications
You must be signed in to change notification settings - Fork 62.1k
Update JFrog GitHub OIDC setup docs #37596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
@EyalDelarea Thanks for opening a PR! 🎉 It looks like this is still a draft. Could you ping me when this is ready? Then, I'll get it up for review ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great! I left a couple comments, please take a look and let me know what you think
...or-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-jfrog.md
Outdated
Show resolved
Hide resolved
...or-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-jfrog.md
Show resolved
Hide resolved
...or-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-jfrog.md
Show resolved
Hide resolved
...or-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-jfrog.md
Outdated
Show resolved
Hide resolved
Thanks! I'll get this triaged now. |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
Hey @Sharra-writes, |
@EyalDelarea If this isn't ready to merge yet, then leaving it as a draft would probably be better. My job will be looking for technical confirmation internally, and I probably can't get confirmation on changes that haven't been made yet! 😆 |
@Sharra-writes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Thank you for raising this and thanks for your patience
I've raised a few comments and questions, and once we've resolved things there won't be any problem with merging this. With a couple of exceptions, almost all of my review comments are related to the GitHub or Microsoft style guides, so if you'd like us to explain any of them then just let us know. Thank you
...or-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-jfrog.md
Outdated
Show resolved
Hide resolved
...or-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-jfrog.md
Outdated
Show resolved
Hide resolved
...or-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-jfrog.md
Outdated
Show resolved
Hide resolved
...or-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-jfrog.md
Outdated
Show resolved
Hide resolved
...or-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-jfrog.md
Outdated
Show resolved
Hide resolved
...or-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-jfrog.md
Outdated
Show resolved
Hide resolved
...or-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-jfrog.md
Outdated
Show resolved
Hide resolved
...or-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-jfrog.md
Outdated
Show resolved
Hide resolved
...or-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-jfrog.md
Outdated
Show resolved
Hide resolved
...or-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-jfrog.md
Show resolved
Hide resolved
…-your-deployments/configuring-openid-connect-in-jfrog.md Co-authored-by: Ben Ahmady <[email protected]>
…-your-deployments/configuring-openid-connect-in-jfrog.md Co-authored-by: Ben Ahmady <[email protected]>
…-your-deployments/configuring-openid-connect-in-jfrog.md Co-authored-by: Ben Ahmady <[email protected]>
…-your-deployments/configuring-openid-connect-in-jfrog.md Co-authored-by: Ben Ahmady <[email protected]>
…-your-deployments/configuring-openid-connect-in-jfrog.md Co-authored-by: Ben Ahmady <[email protected]>
…-your-deployments/configuring-openid-connect-in-jfrog.md Co-authored-by: Ben Ahmady <[email protected]>
…-your-deployments/configuring-openid-connect-in-jfrog.md Co-authored-by: Ben Ahmady <[email protected]>
…-your-deployments/configuring-openid-connect-in-jfrog.md Co-authored-by: Ben Ahmady <[email protected]>
…-your-deployments/configuring-openid-connect-in-jfrog.md Co-authored-by: Ben Ahmady <[email protected]>
I've committed these suggestions to get things moving on this, so we can hopefully get it merged. |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
This change updates the JFrog OIDC integration guide to reflect a recent improvement in the
jfrog/setup-jfrog-cli
GitHub Action. The action now supports seamless OIDC authentication out of the box, removing the need for users to manually exchange tokens via REST API calls.What's being changed (if available, include any code snippets, screenshots, or gifs):
curl
.jfrog/setup-jfrog-cli@v4
withoidc-provider-name
andoidc-audience
inputs.permissions
block (id-token: write
) to the YAML example to ensure OIDC works as expected.Check off the following: