Skip to content

Fix probable typo in JSON example #38624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

Fix probable typo in JSON example #38624

merged 2 commits into from
May 30, 2025

Conversation

yaakov-h
Copy link
Contributor

Why:

this is lowercase in RFC 8693

Closes: #38623

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

this is lowercase in RFC 8693
@Copilot Copilot AI review requested due to automatic review settings May 29, 2025 22:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the casing of a JSON property in the OIDC example to align with RFC 8693.

  • Lowercases the Issued_token_type key to issued_token_type in the JSON snippet.

Copy link
Contributor

github-actions bot commented May 29, 2025

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
copilot/building-copilot-extensions/using-oidc-with-github-copilot-extensions.md fpt
ghec
fpt
ghec

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 29, 2025
@Sharra-writes Sharra-writes removed the triage Do not begin working on this issue until triaged by the team label May 29, 2025
@Sharra-writes
Copy link
Contributor

Thanks for opening a PR! Let me check on this since these things are case sensitive.

@Sharra-writes Sharra-writes added content This issue or pull request belongs to the Docs Content team copilot Content related to GitHub Copilot labels May 29, 2025
@yaakov-h yaakov-h changed the title Fix probably typo in JSON example Fix probable typo in JSON example May 29, 2025
@Sharra-writes
Copy link
Contributor

Okay, confirmed that it should be lower case. I'll get this merged once checks are passing!

@Sharra-writes Sharra-writes enabled auto-merge May 30, 2025 16:51
@Sharra-writes Sharra-writes added this pull request to the merge queue May 30, 2025
Merged via the queue into github:main with commit 8d487f5 May 30, 2025
42 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team copilot Content related to GitHub Copilot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible typo in Copilot OIDC docs
2 participants