-
Notifications
You must be signed in to change notification settings - Fork 62k
Fix probable typo in JSON example #38624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this is lowercase in RFC 8693
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR corrects the casing of a JSON property in the OIDC example to align with RFC 8693.
- Lowercases the
Issued_token_type
key toissued_token_type
in the JSON snippet.
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
Thanks for opening a PR! Let me check on this since these things are case sensitive. |
Okay, confirmed that it should be lower case. I'll get this merged once checks are passing! |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
this is lowercase in RFC 8693
Closes: #38623
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following: