chore: close duplicate code issue - already resolved in #1620#1635
Closed
chore: close duplicate code issue - already resolved in #1620#1635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hardcoded log directory string
"/tmp/gh-aw/mcp-logs"ininternal/config/validation_env.go:143was already replaced with theDefaultLogDirconstant in PR #1620 (commit 341304b).Current State
All three locations now reference the centralized constant:
No code changes needed. This PR documents that the issue was already resolved.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
example.com/tmp/go-build3312100120/b297/launcher.test /tmp/go-build3312100120/b297/launcher.test -test.testlogfile=/tmp/go-build3312100120/b297/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true go t.go 64/pkg/tool/linux_amd64/compile(dns block)invalid-host-that-does-not-exist-12345.com/tmp/go-build3312100120/b279/config.test /tmp/go-build3312100120/b279/config.test -test.testlogfile=/tmp/go-build3312100120/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true /tmp/go-build3312100120/b264/symabis -c=4 -nolocalimports -importcfg /tmp/go-build3312100120/b264/importcfg -pack -asmhdr -d go git /opt/hostedtoolc-nilfunc get-url origin ache/uv/0.10.8/xgithub.com/segmentio/asm/base64 64/pkg/include(dns block)nonexistent.local/tmp/go-build3312100120/b297/launcher.test /tmp/go-build3312100120/b297/launcher.test -test.testlogfile=/tmp/go-build3312100120/b297/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true go t.go 64/pkg/tool/linux_amd64/compile(dns block)slow.example.com/tmp/go-build3312100120/b297/launcher.test /tmp/go-build3312100120/b297/launcher.test -test.testlogfile=/tmp/go-build3312100120/b297/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true go t.go 64/pkg/tool/linux_amd64/compile(dns block)this-host-does-not-exist-12345.com/tmp/go-build3312100120/b306/mcp.test /tmp/go-build3312100120/b306/mcp.test -test.testlogfile=/tmp/go-build3312100120/b306/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true -c=4 -nolocalimports -importcfg /tmp/go-build3312100120/b272/importcfg -pack /home/REDACTED/go/pkg/mod/github.com/modelcontextprotocol/go-sdk@v1.4.0/jsonrpc/jsonrpc.go 64/pkg/tool/linu/tmp/go-build3312100120/b140/vet.cfg -d go which /usr/bin/dirname(dns block)If you need me to access, download, or install something from one of these locations, you can either: