Skip to content

chore: close duplicate code issue - already resolved in #1620#1635

Closed
Claude wants to merge 1 commit intomainfrom
claude/remove-duplicate-log-directory-string
Closed

chore: close duplicate code issue - already resolved in #1620#1635
Claude wants to merge 1 commit intomainfrom
claude/remove-duplicate-log-directory-string

Conversation

@Claude
Copy link
Contributor

@Claude Claude AI commented Mar 6, 2026

The hardcoded log directory string "/tmp/gh-aw/mcp-logs" in internal/config/validation_env.go:143 was already replaced with the DefaultLogDir constant in PR #1620 (commit 341304b).

Current State

All three locations now reference the centralized constant:

// internal/config/config_logging.go
const DefaultLogDir = "/tmp/gh-aw/mcp-logs"

// internal/cmd/flags_logging.go
return envutil.GetEnvString("MCP_GATEWAY_LOG_DIR", config.DefaultLogDir)

// internal/config/validation_env.go
if logDir == "" {
    logDir = DefaultLogDir  // Uses constant, not hardcoded string
}

No code changes needed. This PR documents that the issue was already resolved.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • example.com
    • Triggering command: /tmp/go-build3312100120/b297/launcher.test /tmp/go-build3312100120/b297/launcher.test -test.testlogfile=/tmp/go-build3312100120/b297/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true go t.go 64/pkg/tool/linux_amd64/compile (dns block)
  • invalid-host-that-does-not-exist-12345.com
    • Triggering command: /tmp/go-build3312100120/b279/config.test /tmp/go-build3312100120/b279/config.test -test.testlogfile=/tmp/go-build3312100120/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true /tmp/go-build3312100120/b264/symabis -c=4 -nolocalimports -importcfg /tmp/go-build3312100120/b264/importcfg -pack -asmhdr -d go git /opt/hostedtoolc-nilfunc get-url origin ache/uv/0.10.8/xgithub.com/segmentio/asm/base64 64/pkg/include (dns block)
  • nonexistent.local
    • Triggering command: /tmp/go-build3312100120/b297/launcher.test /tmp/go-build3312100120/b297/launcher.test -test.testlogfile=/tmp/go-build3312100120/b297/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true go t.go 64/pkg/tool/linux_amd64/compile (dns block)
  • slow.example.com
    • Triggering command: /tmp/go-build3312100120/b297/launcher.test /tmp/go-build3312100120/b297/launcher.test -test.testlogfile=/tmp/go-build3312100120/b297/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true go t.go 64/pkg/tool/linux_amd64/compile (dns block)
  • this-host-does-not-exist-12345.com
    • Triggering command: /tmp/go-build3312100120/b306/mcp.test /tmp/go-build3312100120/b306/mcp.test -test.testlogfile=/tmp/go-build3312100120/b306/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true -c=4 -nolocalimports -importcfg /tmp/go-build3312100120/b272/importcfg -pack /home/REDACTED/go/pkg/mod/github.com/modelcontextprotocol/go-sdk@v1.4.0/jsonrpc/jsonrpc.go 64/pkg/tool/linu/tmp/go-build3312100120/b140/vet.cfg -d go which /usr/bin/dirname (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@Claude Claude AI assigned Claude and lpcox Mar 6, 2026
@Claude Claude AI changed the title [WIP] Refactor hardcoded log directory string to use constant chore: close duplicate code issue - already resolved in #1620 Mar 6, 2026
@lpcox lpcox closed this Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants