-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Filter Out CI User Responses from Time to First Response #78
feat: Filter Out CI User Responses from Time to First Response #78
Conversation
Thanks for putting this together! We should also add a test that exercises ignored users in a comment and a review. Let me know if you would like some help with any of that. |
Thank you!! I've added two test cases for ignoring users. Are they reflected correctly? |
Thanks for adding the tests! I also debugged locally and confirmed that only 1 comment or review comment was being put into the iterator and when I made the fd029d1 it now has multiple comments in the iterators for checking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thanks for another wonderful contribution!! I'll personally be using this now to exclude bot accounts when I use this action. Much appreciated!
ref. #65
What
IGNORE_USERS
environment variable are now excluded from Time to First Response calculations.Note
The user who wrote the comment can be got by the following API.