Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Filter Out CI User Responses from Time to First Response #78

Merged
merged 10 commits into from
Aug 1, 2023

Conversation

Okabe-Junya
Copy link
Contributor

@Okabe-Junya Okabe-Junya commented Jul 29, 2023

ref. #65

What

  • Users listed in the IGNORE_USERS environment variable are now excluded from Time to First Response calculations.
  • update README

Note

The user who wrote the comment can be got by the following API.

time_to_first_response.py Outdated Show resolved Hide resolved
time_to_first_response.py Outdated Show resolved Hide resolved
@zkoppert zkoppert added the enhancement New feature or request label Jul 31, 2023
@zkoppert
Copy link
Member

Thanks for putting this together!

We should also add a test that exercises ignored users in a comment and a review. Let me know if you would like some help with any of that.

@Okabe-Junya
Copy link
Contributor Author

Thank you!!

I've added two test cases for ignoring users. Are they reflected correctly?

@zkoppert
Copy link
Member

zkoppert commented Aug 1, 2023

Thanks for adding the tests! I also debugged locally and confirmed that only 1 comment or review comment was being put into the iterator and when I made the fd029d1 it now has multiple comments in the iterators for checking.

Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for another wonderful contribution!! I'll personally be using this now to exclude bot accounts when I use this action. Much appreciated!

@zkoppert zkoppert merged commit 92b849a into github:main Aug 1, 2023
4 checks passed
@Okabe-Junya Okabe-Junya deleted the junya/feat/add-ignore-users branch August 2, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants