fix: ensure release label is used with semver labels #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the release workflow to require both a release label and a semver label (major, minor, or patch) for version bumps, preventing accidental releases from automated PRs like Dependabot.
- Modifies the release condition logic to require explicit
release+ semver label combinations - Updates documentation to reflect the new dual-label requirement
- Replaces the previous warning about Dependabot conflicts with clear usage instructions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Updates documentation to explain the new dual-label requirement for releases |
| .github/workflows/release.yaml | Modifies release conditions to require both release and semver labels together |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Update README noting this new requirement Signed-off-by: jmeridth <[email protected]>
jmeridth
force-pushed
the
jm_ensure_semver_labels_are_used_with_release_label
branch
from
ad3f64f to
b713cd2
Compare
jmeridth
changed the title
jmeridth
deleted the
jm_ensure_semver_labels_are_used_with_release_label
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README noting this new requirement