feat: additional metrics for days since last release and PR #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zack Koppert <[email protected]>
zkoppert
commented
Jun 8, 2024
Comment on lines
+157
to
+186
| def get_days_since_last_release(repo): | ||
| """Get the number of days since the last release of the repository. | ||
|
|
||
| Args: | ||
| repo: A Github repository object. | ||
|
|
||
| Returns: | ||
| The number of days since the last release. | ||
| """ | ||
| try: | ||
| last_release = next(repo.releases()) | ||
| return (datetime.now(timezone.utc) - last_release.created_at).days | ||
| except StopIteration: | ||
| return None | ||
|
|
||
|
|
||
| def get_days_since_last_pr(repo): | ||
| """Get the number of days since the last pull request was made in the repository. | ||
|
|
||
| Args: | ||
| repo: A Github repository object. | ||
|
|
||
| Returns: | ||
| The number of days since the last pull request was made. | ||
| """ | ||
| try: | ||
| last_pr = next(repo.pull_requests(state="all")) | ||
| return (datetime.now(timezone.utc) - last_pr.created_at).days | ||
| except StopIteration: | ||
| return None |
There was a problem hiding this comment.
Core functionality change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
fixes #20
Proposed Changes
This pull request introduces a new feature that allows it to report additional metrics about repositories, such as the number of days since the last release or the last pull request. The changes also include updates to the
.env-exampleandREADME.mdfiles to reflect the new feature, and modifications to thestale_repos.pyandtest_stale_repos.pyfiles to implement and test the new functionality.One major technical change internally is that the inactive repos list is now structured as a list of dictionaries, with each dictionary containing the repository name, the number of days since the last release, and the number of days since the last pull request. This change was necessary to accommodate the new metrics each individually being optional.
I've ensured that the tests passed and also ran this locally against the github org with the expected results.
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducing@jeffrey-luszczReviewer
fix,documentation,enhancement,infrastructure,maintenanceorbreaking