Stop variant analysis from published pack if no language selected #3261
Conversation
| @@ -223,6 +223,9 @@ export class VariantAnalysisManager | |||
| }); | |||
|
|
|||
| const language = await askForLanguage(this.cliServer); | |||
| if (!language) { | |||
There was a problem hiding this comment.
Does this have any behavioural effect right now? We're using the default value of throwOnEmpty = true so it should throw a UserCancellationException if the user doesn't select a language? Is that how it works?
Regardless there are still some code paths where it still returns undefined, and I agree we should abort in this case.
Aborting without logging anything should be fine. As far as I can tell we'll always have already logged the reason when returning undefined from askForLanguage.
There was a problem hiding this comment.
Does this have any behavioural effect right now? We're using the default value of
throwOnEmpty = trueso it should throw aUserCancellationExceptionif the user doesn't select a language? Is that how it works?
Ah yeah it looks like there is no behaviour change. That's how I'm reading the code too.
So this will mainly make the types a bit nicer.
Tiny change to stop processing a variant analysis using a published back if the user doesn't select a language.
Checklist
N/A - the functionality being changed is behind an unveiled feature flag:
ready-for-doc-reviewlabel there.