Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic multi-query support to MRVA results view header #3286

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

charisk
Copy link
Contributor

@charisk charisk commented Jan 29, 2024

Adds a very minimal solution to showing query information for a multi-query MRVA in the results view. This is something we'll expand on in the future.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner January 29, 2024 11:20
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. One small optional comment.

As said earlier, I think merging this now is a good idea so we improve the UI a little bit, and it doesn't block us doing more later.

@charisk charisk enabled auto-merge (squash) January 29, 2024 11:49
@charisk charisk merged commit 1b84906 into main Jan 29, 2024
15 checks passed
@charisk charisk deleted the charisk/multi-query-mrva-results branch January 29, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants