Use type 'string | Buffer' for process stdout/stderr #3329
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention here is to avoid use of
any
when logging process stdout/stderr. This data comes to us in chunks which we want to calltoString()
on. We can do that with type safety if we introduce aasString
method (very open to other names).The only issues are the
null
andundefined
values. In this I've gone with returning human-readable values since we're printing this to a log, but we could return the empty string instead. In practice I expect these values to never actually happen.Checklist
ready-for-doc-review
label there.