fix(visual): stop fixture window from covering Linux bottom panels#32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #31 made the fixture window opaque white (to fix GNOME bleed-through), Budgie and Cinnamon started failing: their default panels are at the bottom of the screen, and our window snaps to the bottom-right corner (because
tray.getBounds()returns{0,0,0,0}on Linux SNI, so menubar's Positioner falls back). The opaque white window now sits right on top of the tray icon →exactTray=0, test fails. KDE Plasma showed the same hang/failure pattern.Previously the window was transparent (Electron default on Linux) so the tray showed through.
Fix: explicitly
mb.window.setPosition(400, 200)aftershowWindow(). Mid-screen placement guarantees no overlap with any panel (top or bottom) on any platform. On macOS/Windows the visual diff just moves where the white box appears in the masked screenshot — relative position doesn't matter for diffing.Test plan