fix(visual): make sway respect window size and stop GNOME painting it blue#34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two cosmetic fixes for the residual platforms after the white-box marker landed:
Sway: window tiled to fill the workspace
Sway is a tiling compositor and ignores Electron's 200x100 size request, stretching the fixture to fill all available space. Added a
for_windowrule to the test's Sway config that matches by the HTML<title>("menubar visual fixture") and forces the window floating + 200x100 + position (400, 200). Same dimensions and position as every other platform now.GNOME: window paints navy-blue instead of white
Mutter was either painting a CSD header bar accent in our window region, or rendering it as "unfocused" with a dimming tint — either way our
backgroundColor: '#FFFFFF'wasn't visible. Three changes to the fixture'sbrowserWindowopts:frame: false: no CSD header bar, no Mutter accent strip inside our 200x100 rect.useContentSize: true: 200x100 is now the content size; without this, the inner HTML viewport was smaller than 200x100 because Electron sized the outer rect.mb.window.focus()aftersetPosition: stops Mutter rendering the window with its "unfocused window" tint.Test plan