feat(gcp-runner): manage IAM for pre-created accounts - #61
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
nandajavarma
marked this pull request as ready for review
July 20, 2026 10:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional
attach_iam_policiesfield topre_created_service_accounts.The field defaults to
false, preserving existing behavior for deployments that manage IAM outside the module. When set totrue, the module creates the runner and proxy custom roles and attaches the required project-level and per-service-accountroles/iam.serviceAccountUsergrants while continuing to use, rather than create, the supplied service accounts.Deprecated
build_cache,secret_manager, andpubsub_processorfields remain accepted for backward compatibility. Resource-scoped access to infrastructure created by the module is unchanged.Compatibility
attach_iam_policiespreserves the current plan behavior.falsepreserves external IAM management.truerequires the Terraform deployer to create custom roles and update IAM policies.Issues
Fixes CORE-8958
How to test
terraform fmt -check -recursiveterraform validatefalse.attach_iam_policies = trueand confirmed IAM management and custom-role creation resolve totrue.Documentation
The module IAM guide is updated in this PR.
Public Ona documentation: https://github.com/gitpod-io/gitpod-next/pull/28178