feat(custom-domain): add multi-region PSC client module - #70
Closed
nandajavarma wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Codex <noreply@openai.com>
Collaborator
Author
|
Closing this PR because multi-region service attachments are producer-owned. The customer module should remain single-region and receive the attachment URI for the same region. The replacement Terraform work will live in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a separate multi-region custom-domain client module without changing the existing regional module or its Terraform resource addresses.
The module:
X-Gitpod-GCP-IDbefore requests reach the relayus-central1first and addingus-east4when its producer attachment existsA new module is intentional: converting the current regional resources to
for_eachand global resources would change existing Terraform addresses and force migration for current users.Deployment prerequisites
This PR consumes regional service attachments; it does not publish them. Before adding a region, the producer must:
Multiple consumer NEGs provide full regional availability only when the producer also has independent relay capacity in each region.
Related PRs
Part of CORE-8952.
Validation
terraform fmt -check -recursiveterraform init -backend=false && terraform validateterraform init -backend=false && terraform validateterraform init -backend=false && terraform validate