-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conventional Commit Popup #2486
Open
tkr-sh
wants to merge
51
commits into
gitui-org:master
Choose a base branch
from
tkr-sh:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
18fa349
compiles
tkr-sh 24998b2
wip
tkr-sh 8461184
CodeStyle
tkr-sh 4fe9878
wip
tkr-sh 451d25c
🚧 wip
tkr-sh 6149b73
✨ feat: move cursor to end
tkr-sh 656306d
✨ feat: when 1 possible value => next
tkr-sh 7f01b0a
🐛 fix: when there are no default msg => no `:`
tkr-sh 0da4025
💬 fix: appropriate title for widget
tkr-sh 491bebb
🐛 fix: bad display for selection of commit type
tkr-sh b112792
✨ feat: use proper char for shortcut char
tkr-sh 637f834
🐛 fix: made shortcuts work
tkr-sh b79e6cb
🔇 debug: remove logs
tkr-sh 562b210
🐛 fix: close instead of enter
tkr-sh 557bc88
🔇 refactor: remove doc
tkr-sh d00ffda
✨ feat: filtering on query working
tkr-sh 732e0b9
♻️ ref: make selected lines take 100% width
tkr-sh ca041d7
✨ feat: add commands indication
tkr-sh 66d3b59
✨ feat: "INSERT" text when in insert mode
tkr-sh 736263e
♻️ refactor: put next_step actions in fn
tkr-sh d3d75b6
🎨 style: style
tkr-sh fe22a15
✨ feat: new more_info (Formatted)
tkr-sh 0ee2242
✨ feat!: add breaking changes
tkr-sh 366f08e
♻️ refactor: remove .unwrap()
tkr-sh 580e28f
⚠️ fix: warning / clippy
tkr-sh 96000cb
✨ feat: optional gitmojis
tkr-sh f811413
✏️ fix: s/Commit emoji/Conventional commit
tkr-sh a3284e5
🩹 fix: cursor to end
tkr-sh 2d7cc74
🔊 debug: add logs
tkr-sh 20d5a2c
♻️ refactor: add dead_code back
tkr-sh 8d72f28
✏️ fix: s/commit_emoij/conventional_commit
tkr-sh 15ad7d0
✏️ fix: typo
tkr-sh 4c59e63
✏️ fix: typo
tkr-sh 57dc1ae
🏗️ refactor: move "Conventional Commit"
tkr-sh f1c86d9
📝 docs: move comments to doc ones
tkr-sh 29fbfc9
⚠️ fix: warning
tkr-sh 9645901
🐛 fix: when empty, don't panic with []
tkr-sh 12b2c92
💅 style: fmt
tkr-sh b4270f5
♻️ refactor: use consts instead of magic &str
tkr-sh d054086
♻️ refactor: use Borrow<str> instead of &str
tkr-sh 5c92e33
♻️ refactor: rm duplicated code
tkr-sh ae1af08
🐛 fix: bug when 1 res != open commit
tkr-sh ae06c25
🩹 fix: remove unused reference
tkr-sh 40f8077
🩹 fix:previously inverted order of commit title
tkr-sh 8465c3f
🐛 fix: clamp max depending on phase
tkr-sh 80e3f9f
Merge branch 'gitui-org:master' into master
tkr-sh cb20254
🩹 fix: add the scroll keys
tkr-sh bb78714
♻️ refactor: add more feature gating
tkr-sh 558bffb
♻️ refactor: never collect the list block
tkr-sh 28d8ff5
♻️ refactor: derive IntoStaticStr
tkr-sh dc0936e
♻️ refactor: use clear instead of set_text
tkr-sh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
making this default on will be controversial. I remember we did that in the past and it bloats the binary for a lot of people that are not interested in this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it can be true sometimes, but in this specific case I don't think that it's a good argument because
(12944B diff ≈ 0.086% of the total binary size, tested at bb78714)
But you could make the point that most people don't want gitmoji, and in this case, removing it as a default feature is understandable.