Repair build on nightly and new MSRV 1.81 #2582
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naseschwarz
changed the title
naseschwarz
changed the title
naseschwarz
force-pushed
the
build-msrv
branch
2 times, most recently
from
2101dc8 to
cb7049e
Compare
Somehow at some point, additional rust toolchains became available in CI. Thus, it's no longer sufficient to install the matrix toolchain, but actually override it for the build directory.
naseschwarz
changed the title
|
If I'm not missing something, there'll be a lot of dependency downgrades if we want to keep the MSRV at 1.70, including at least a rustsec unmaintained advisory and other complications. @extrawurst: Is an MSRV at 1.70 just a nice-to-have or something we should strive for? I agree that 1.70 is a reasonable default, but as seeing the state of the dependencies I'm not sure it's worth going for. gitui's actual MSRV is 1.81 for the time being. |
|
Yeah let's upgrade the MSRV, that will unlock a lot of nice things and it was originally for Debian but keeping compatibility with its off-the-shelve rust version is insane. I am willing to give up on that. people have to install a rust toolchain anyway for getting anything recent to build on it :) |
naseschwarz
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, nightly and MSRV builds don't activate their respective toolchains. Thus, MSRV and nightly builds are broken.
This is just a draft enabling the toolchains for now until the builds are fixed, too.
Current state:
Fix 1.70 builds oragree on higher MSRVThis Pull Request fixes/closes #2094
It changes the following:
I followed the checklist:
I added unittestsN/AI ran-> CImake checkwithout errors