Repair build on nightly and new MSRV 1.81 #2613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 15, 2025 15:06
Somehow at some point, additional rust toolchains became available in CI. Thus, it's no longer sufficient to install the matrix toolchain, but actually override it for the build directory.
extrawurst
reviewed
Apr 15, 2025
added 3 commits
April 15, 2025 19:26
This is entirely clippy-motivated:
error: unnecessary `Debug` formatting in `println!` args
--> src/args.rs:142:46
|
142 | println!("Logging enabled. Log written to: {path:?}");
| ^^^^
|
= help: use `Display` formatting and change this to `path.display()`
= note: switching to `Display` formatting will change how the value is shown; escaped characters will no longer be escaped and surrounding quotes will be removed
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_debug_formatting
note: the lint level is defined here
--> src/main.rs:9:53
|
9 | #![deny(clippy::all, clippy::perf, clippy::nursery, clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[deny(clippy::unnecessary_debug_formatting)]` implied by `#[deny(clippy::pedantic)]`
|
awesome thanks! so many new nice things. there is probably also a ton of clippy-allows we can revisit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2094
It changes the following:
I followed the checklist:
I added unittestsmake checkwithout errors