Use defconst for a defvar & a constant predicate function. Allow toggling format on save. #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The `gleam-ts--grammar-revision' is not meant to be modified. Changed it from defvar to defconst. * The `gleam-ts--grammar-supports-echo-keyword-p' predicate function only depends on `gleam-ts--grammar-revision'; it can also become a defconst. Being defconst identify the fact that this is not changeable during an Emacs sessions.
pierre-rouleau
changed the title
|
Note that this change does not change the way the code works. It makes it explicit that the values should not be changed, and always set the value, even if it was previously bound. It does not (at least with Emacs 30) prevent code from changing the value though. |
* Instead of hooking the `gleam-ts-format` to `before-save-hook` when the mode
is loaded, hook the function `gleam-ts--format-on-save-maybe`. That
function performs the formatting only when `gleam-ts-format-on-save` is
non-nil.
- Doing it this way means that the user can toggle the value of
`gleam-ts-format-on-save` at any time, during an Emacs session and the
change takes effect right away. That was not possible with the previous
code: the user had to exit Emacs to activate the change.
* Also minor code format in the `gleam-ts--font-lock-settings` to comply
with standard Elisp formatting rules.
|
The latest change allows users to toggle format on save, a useful feature in various scenarios. This way you can activate or de-activate the mechanism just in the current session without modifying the persistent customizable user-option. |
pierre-rouleau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gleam-ts--grammar-revisionis not meant to be modified. Changed it from defvar to defconst.gleam-ts--grammar-supports-echo-keyword-ppredicate function only depends ongleam-ts--grammar-revision; it can also become a defconst.Being defconst identify the fact that this is not changeable during an Emacs sessions.