Add more punctuation to split_and_normalise_words #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added parentheses, square brackets, questions marks, double quotes, em dashes, colons, and semicolons
Forgot to actually include the question mark last time
lpil
reviewed
Oct 24, 2025
Member
lpil
left a comment
lpil
left a comment
There was a problem hiding this comment.
Could you add a test for the paint example that failed please 🙏
Contributor
Author
|
Of course! I've done that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the following list of punctuation to be replaced by " " or "" before indexing occurs.
This should ensure that cases like
are handled correctly and that the
paintpackage (whose description is above) shows up when someone searches for "canvas", without them having to search for "canvas)".