-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
a few optimizations for dashboards #21988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a few optimizations for dashboards #21988
Conversation
trasher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will have to remove the is_template and is_deleted keys to fix tests.
I do not know if you plan other improvements, but those ones shoudl target next release I guess.
Probably only is_deleted as it's the first is the construction of the composite key, is_template is still required/ |
|
TODO: cache management for filters isn't clearable at the moment, and I need to find another way to store/delete. Edit: done by a short ttl |
Co-authored-by: Johan Cwiklinski <[email protected]>
Co-authored-by: Cédric Anne <[email protected]>
AdrienClairembault
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are PHPStan errors
Description
Filter::getAppliableFilterswhere most of the hit was