Restrict webhooks by itemtype #21989
Merged
+55
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-anne
reviewed
Nov 19, 2025
| public function canCreateItem(): bool | ||
| { | ||
| $itemtype = $this->fields['itemtype']; | ||
| return empty($itemtype) || (is_subclass_of($itemtype, CommonGLPI::class) && $itemtype::canView()); |
Member
There was a problem hiding this comment.
Should be allow creation of hooks not related to any itemtype?
Contributor
Author
There was a problem hiding this comment.
Not really, but those webhooks wouldn't be usable at all so from a restriction standpoint it isn't a big deal. There is already a block in Webhook::handleInput when the itemtype is missing. The empty check here was more to prevent errors in the subclass/canView check.
trasher
approved these changes
Nov 20, 2025
AdrienClairembault
approved these changes
Nov 21, 2025
cedric-anne
merged commit f1d7635
into
glpi-project:11.0/bugfixes
13 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Adds a few restrictions for webhook management.