FIX / Add saved searches functionality for simplified interface users

[Mary-Clb]

Checklist before requesting a review

• I have read the CONTRIBUTING document.
• I have performed a self-review of my code.
• I have added tests that prove my fix is effective or that my feature works.
• This change requires a documentation update.

Description

It fixes !40229
Saved searches were no longer accessible for users with simplified interface, while they were available in version 10. This fix restores the ability to access and save search queries for helpdesk users.

Technical Changes

Modified Files:

1. Profile.php

Added bookmark_public to $helpdesk_rights array
Added SavedSearch to tools section in getRightsForForm() for helpdesk interface

2. SavedSearchFormController.php

Added security strategy imports (Firewall, SecurityStrategy)
Changed security strategy from default STRATEGY_CENTRAL_ACCESS to STRATEGY_AUTHENTICATED
This allows both central and helpdesk interface users to access the controller

[AdrienClairembault]

Just tested it quickly and there are a few issues:

1) The save saved search button is still shown in the search UI even if the user does not have the new right:

So, the user will still get the error page in the case.
It would be better to not add the button if the user can't use the searches.

2) I can only save a search if I check the "READ" right (not "CREATE", which seems to do nothing.)

3) I can see saved searches on other types:

I think on self service only the ticket tab should be shown, here "aaaa" is a saved search on computer so I get an error if I click it.

4) And finally, do we need really need a configurable right for this? ping @orthagh
I don't know how it worked on GLPI 10 but I don't see why you would prevent an user from creating saved searches.

[cconard96]

AFAIK, everyone should always be able to create private saved searches (no rights associated) while public saved searches were only available in the standard interface.

[Mary-Clb]

Please let me know if these modifications are better :

• SavedSearch.php: Added canView() method override to allow access in helpdesk interface for private searches
• Profile.php: Remove saved search right configuration from helpdesk interface rights

[AdrienClairembault]

Looks good, just one small detail:

When I save a search, I am redirected to this page:

On GLPI 10, I would instead be redirected to the current search page, which seems more logical.

To achieve this, I think you'll need to override the getPostFormAction() method and make sure it returns back if the user is a self service user.