fix returns on PHPDoc only #22014
Merged
fix returns on PHPDoc only #22014
+19
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
IMHO, you can replace |
trasher
reviewed
Nov 21, 2025
Contributor
Author
|
Lint checks are broken ? Did the checks locally and no problems... |
Contributor
There are network problems today with some services... :/ |
froozeify
approved these changes
Nov 24, 2025
trasher
reviewed
Nov 24, 2025
trasher
approved these changes
Nov 24, 2025
Contributor
trasher
left a comment
trasher
left a comment
There was a problem hiding this comment.
Excepted useless changes (see comments), LGTM.
cedric-anne
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a rework on the declined previous PR : #22002
It fixes #21794 after creating a new branch based on up-to-date 11.0/bugfixes
Only PHPDoc annotations.
Got a doubt though on showFor* methods in
src/Change_Ticket.phpandsrc/Change_Problem.php: PHPStan accept ONLYvoid|falsebut adding areturn;statement could be an option (return+voidis rejected by PHPStan so i'm open to any suggestion on those cases).