fix: typo in return type of DateTime.time()
#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you @mttbernardini for your attention to detail! |
This commit was sponsored by Matt Campbell, Blaise Pabon, Cassie Jones, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Blaise Pabon, Matt Campbell, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
c.f. python/mypy#4717 This commit was sponsored by Blaise Pabon, Matt Campbell, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
glyph
approved these changes
Feb 14, 2025
Owner
glyph
left a comment
glyph
left a comment
There was a problem hiding this comment.
Obviously the fix here is correct, so I will address the testing issues, which I think are incidental.
This commit was sponsored by Blaise Pabon, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Blaise Pabon, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Blaise Pabon, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.