Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More unused header removal #406

Closed
wants to merge 9 commits into from
Closed

More unused header removal #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3534c31
Removed unused imports
jkoutavas Oct 7, 2019
20cda67
Moved PSMTabBarControl import from iTermPreferences header to its imp…
jkoutavas Oct 7, 2019
cfde8c5
Another unused header
jkoutavas Oct 8, 2019
49f2a8c
Another unneeded import
jkoutavas Oct 8, 2019
75cf647
More removal of unused imports
jkoutavas Oct 12, 2019
76dd0e1
Merge commit '9e966cbc2bbe6176e0ff3f7a15cec27e8e95b169' into jay/unus…
jkoutavas Oct 12, 2019
49e920f
Need this import
jkoutavas Oct 12, 2019
fba12f1
Rolled-back some of my over-zealous #import removals from PTYSession.…
jkoutavas Oct 13, 2019
846c83f
Further division of labor, at the #import clean-up level
jkoutavas Oct 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sources/NSStringITerm.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
#import "iTermMalloc.h"
#import "iTermSwiftyStringParser.h"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

#import "iTermTuple.h"
#import "iTermVariableScope.h"
#import "NSArray+iTerm.h"
#import "NSData+iTerm.h"
#import "NSLocale+iTerm.h"
Expand Down
1 change: 0 additions & 1 deletion sources/PTYScrollView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
#import "iTermAdvancedSettingsModel.h"
#import "iTermScrollAccumulator.h"
#import "NSView+iTerm.h"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

#import "PreferencePanel.h"
#import "PTYScrollView.h"
#import "PTYTextView.h"

Expand Down
5 changes: 0 additions & 5 deletions sources/PTYSession.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,23 @@
// Implements the model class for a terminal session.

#import "Api.pbobjc.h"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used in this file. For example, ITMGetBufferResponse. Anything with the ITM prefix comes from the protobufs. However, since only objects are ever referenced this import could be replaced with forward references like @class ITMGetBufferResponse for each referenced symbol.

#import "DVR.h"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

#import "iTermAPIHelper.h"
#import "iTermEchoProbe.h"
#import "iTermFindDriver.h"
#import "iTermFileDescriptorClient.h"
#import "iTermMetalUnavailableReason.h"
#import "iTermWeakReference.h"
#import "ITAddressBookMgr.h"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file uses iTermSessionEndAction from this include.

#import "iTermPopupWindowController.h"
#import "iTermSessionNameController.h"

#import "GPBEnumArray+iTerm.h"
#import "LineBuffer.h"
#import "PTYTask.h"
#import "PTYTextView.h"
#import "ProfileModel.h"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the Profile macro in this file, which is defined in ProfileModel.h

#import "TextViewWrapper.h"
#import "TmuxController.h"
#import "TmuxGateway.h"
#import "VT100Screen.h"
#import "VT100ScreenMark.h"
#import "WindowControllerInterface.h"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can replace this with @interface WindowControllerInterface, which is used below

#import <AppKit/AppKit.h>
#import <Foundation/Foundation.h>
#include <sys/time.h>
Expand Down
1 change: 0 additions & 1 deletion sources/SessionView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
*/

#import <Cocoa/Cocoa.h>
#import "iTermFindDriver.h"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SessionView conforms to the iTermFindDriverDelegate protocol declared in this header

#import "iTermMetalDriver.h"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

#import "PTYScrollView.h"
#import "PTYSession.h"
Expand Down
1 change: 0 additions & 1 deletion sources/SessionView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
#import "PTYScrollView.h"
#import "PTYSession.h"
#import "PTYTab.h"
#import "PTYTextView.h"
#import "PTYWindow.h"
#import "SessionTitleView.h"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

#import "SplitSelectionView.h"
Expand Down