feat(examples): add `bitset` package by jeronimoalbi · Pull Request #5430 · gnolang/gno

jeronimoalbi · 2026-04-04T16:02:43Z

No description provided.

jeronimoalbi · 2026-04-04T16:03:10Z

The main purpose of this package right now is to be used to implement a bloom filter package

Gno2D2 · 2026-04-04T16:03:17Z

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

IGNORE the bot requirements for this PR (force green CI check)

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:

Fix any issues flagged by automated checks.
Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include BREAKING CHANGE notes.
- Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

Debug

Automated Checks
Maintainers must be able to edit this pull request (more info)
If
🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: jeronimoalbi/gno)
Then
🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met
└── 🟢 On every pull request
Can be checked by

Any user with comment edit permission

notJoon · 2026-04-06T10:43:15Z

examples/gno.land/p/jeronimoalbi/bitset/bitset.gno

+
+// And performs an in-place AND with other bitset.
+// Current bitset grows if the other bitset is bigger.
+func (b *BitSet) And(other BitSet) {


if b is longer than other, the bits outside the range of other seems would not be handled.

Good point, nice catch!

Fixed in 78e3c51

davd-gzl

Looks good otherwise!

davd-gzl · 2026-04-07T15:37:07Z

examples/gno.land/p/jeronimoalbi/bitset/bitset.gno

+
+// Set turns on the bit at a given position.
+func (b *BitSet) Set(i int) {
+	idx := wordIndex(i)


This panic if i < -64
-65 / 64 = -1
idx == -1, b.grow(-1) == noop
b.words[-1] => out of bounds, panic

davd-gzl · 2026-04-07T15:45:28Z

examples/gno.land/p/jeronimoalbi/bitset/bitset.gno

+func (b BitSet) Test(i int) bool {
+	idx := wordIndex(i)
+	if idx >= len(b.words) {
+		return false // Bit has not been setted yet


Suggested change

return false // Bit has not been setted yet

return false // Bit has not been set yet

davd-gzl · 2026-04-07T15:51:08Z

examples/gno.land/p/jeronimoalbi/bitset/bitset.gno

+	return s
+}
+
+func (b *BitSet) grow(idx int) {


Should grow take a length instead of an idx? Almost every call subtract one to its value, and this function add 1 back.
And personally I think it makes more sense to grow to a length instead of an index.

davd-gzl · 2026-04-07T15:57:27Z

examples/gno.land/p/jeronimoalbi/bitset/bitset.gno

+func (b BitSet) String() string {
+	var s string
+	for _, w := range b.words {
+		s += strconv.FormatUint(w, 2)


You should zero-pad values to have a correct binary representation

feat: add bitset package

3690dd0

jeronimoalbi self-assigned this Apr 4, 2026

github-project-automation bot added this to 🧙‍♂️Gno.land development and 💪 Bounties & Worx Apr 4, 2026

github-project-automation bot moved this to Triage in 🧙‍♂️Gno.land development Apr 4, 2026

github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Apr 4, 2026

Merge branch 'master' into feat/jeronimoalbi-bitset-package

3772230

jeronimoalbi requested a review from thehowl April 4, 2026 16:27

jeronimoalbi mentioned this pull request Apr 6, 2026

Create a bloom package that implements bloom filters #5432

Open

notJoon reviewed Apr 6, 2026

View reviewed changes

jeronimoalbi added 3 commits April 6, 2026 15:28

fix: change And to turn off extra bits when other bitset is smaller

78e3c51

test: change And, Or and Xor unit test to table tests

b2f89f7

Merge branch 'master' into feat/jeronimoalbi-bitset-package

fd010c6

davd-gzl reviewed Apr 7, 2026

View reviewed changes

	return false // Bit has not been setted yet
	return false // Bit has not been set yet

Conversation

jeronimoalbi commented Apr 4, 2026

Uh oh!

jeronimoalbi commented Apr 4, 2026

Uh oh!

Gno2D2 commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛠 PR Checks Summary

Manual Checks (for Reviewers):

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Can be checked by

Uh oh!

notJoon Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

jeronimoalbi Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

jeronimoalbi Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

davd-gzl left a comment

Choose a reason for hiding this comment

Uh oh!

davd-gzl Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

davd-gzl Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

davd-gzl Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

davd-gzl Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Gno2D2 commented Apr 4, 2026 •

edited

Loading