Skip to content

feat(gnoland): add version subcommand and fix RPC version#5433

Draft
aeddi wants to merge 5 commits intognolang:masterfrom
aeddi:gnoland-version
Draft

feat(gnoland): add version subcommand and fix RPC version#5433
aeddi wants to merge 5 commits intognolang:masterfrom
aeddi:gnoland-version

Conversation

@aeddi
Copy link
Copy Markdown
Contributor

@aeddi aeddi commented Apr 6, 2026

Edit: I missed this PR 391938e. I’m going to switch this one to draft while I resolve the conflicts and see if there’s anything worth keeping

This PR:

  • Add a gnoland version subcommand (mirrors gnokey version and gno version)
  • Inject build version via ldflags for both gnoland and gnokey (Makefile + goreleaser)
  • Fix NodeInfo.Version in RPC /status to report the actual software version instead of the TM2 protocol version

Before this PR, NodeInfo.Version (returned by the /status RPC endpoint) was set to the TM2 protocol version ("v1.0.0-rc.0"), which I suspect is an error/oversight. This should be the node version, not just the protocol version, which is already provided here:NodeInfo.VersionSet["bft"].

Not fully sure about these two points, but they seemed like the right thing to do:

  • make install.gnokey now uses GOBUILD_FLAGS, previously only make build.gnokey injected the version via ldflags. This seemed like an oversight so I fixed it.
  • NodeInfo.Software is now set to gnoland, this field existed in the struct but was never populated.

@Gno2D2
Copy link
Copy Markdown
Collaborator

Gno2D2 commented Apr 6, 2026

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: aeddi/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@aeddi aeddi marked this pull request as draft April 6, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚀 ci 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants