feat(gnoland): add version subcommand and fix RPC version#5433
Draft
aeddi wants to merge 5 commits intognolang:masterfrom
Draft
feat(gnoland): add version subcommand and fix RPC version#5433aeddi wants to merge 5 commits intognolang:masterfrom
aeddi wants to merge 5 commits intognolang:masterfrom
Conversation
Collaborator
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit: I missed this PR 391938e. I’m going to switch this one to draft while I resolve the conflicts and see if there’s anything worth keeping
This PR:
gnoland versionsubcommand (mirrorsgnokey versionandgno version)gnolandandgnokey(Makefile + goreleaser)NodeInfo.Versionin RPC/statusto report the actual software version instead of the TM2 protocol versionBefore this PR,
NodeInfo.Version(returned by the/statusRPC endpoint) was set to the TM2 protocol version ("v1.0.0-rc.0"), which I suspect is an error/oversight. This should be the node version, not just the protocol version, which is already provided here:NodeInfo.VersionSet["bft"].Not fully sure about these two points, but they seemed like the right thing to do:
make install.gnokeynow usesGOBUILD_FLAGS, previously onlymake build.gnokeyinjected the version via ldflags. This seemed like an oversight so I fixed it.NodeInfo.Softwareis now set tognoland, this field existed in the struct but was never populated.