fix(gnovm): track block item allocations in PrepareNewValues#5436
Open
omarsy wants to merge 6 commits intognolang:masterfrom
Open
fix(gnovm): track block item allocations in PrepareNewValues#5436omarsy wants to merge 6 commits intognolang:masterfrom
omarsy wants to merge 6 commits intognolang:masterfrom
Conversation
Collaborator
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
PrepareNewValues appends new block items to the package block's Values slice without calling AllocateBlockItems. This causes GC recount to exceed the allocator's tracked bytes, triggering a spurious "should not happen, allocation limit exceeded while gc." panic instead of the correct "allocation limit exceeded". Add AllocateBlockItems call before appending to block.Values so the allocator and GC recount stay consistent.
b2d091b to
0057c3c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The added AllocateBlockItems call in PrepareNewValues increases gas consumption by 40-80 bytes per affected code path. Update expected gas values in integration tests and gas_test.go accordingly.
910c2ac to
d758618
Compare
davd-gzl
approved these changes
Apr 6, 2026
Member
davd-gzl
left a comment
There was a problem hiding this comment.
Are there any other similar vulnerabilities in the code-base?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"should not happen, allocation limit exceeded while gc."panic during infinite recursionPrepareNewValuesappends block items without callingAllocateBlockItems, so GC recount exceedsalloc.bytesAllocateBlockItemscall before appending toblock.ValuesinPrepareNewValuesGetLocalIndexdebug loggingTest plan
alloc_12.gnoverifies infinite recursion triggers correct "allocation limit exceeded" errorconst.gno,nested_alloc.gno,slice_alloc.gnogo test ./gnovm/pkg/gnolang/passesgnovm/adr/prxxxx_fix_gc_alloc_mismatch.mdNote: AI assisted PR — see ADR for detailed analysis.