feat(gnovm): add code_submission_policy vm param#5885
Draft
moul wants to merge 1 commit into
Draft
Conversation
Add CodeSubmissionPolicy (permissionless|permissioned) and CodeSubmitters allowlist to vm Params. When policy is permissioned, an ante-handler check rejects MsgAddPackage and MsgRun from any address not on the allowlist — before typechecking runs. Defaults to permissionless; existing chains are unaffected.
Collaborator
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):No automated checks match this pull request. ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Phase 1 of the code-submission permissioning design (gist).
code_submission_policy("permissionless"|"permissioned") andcode_submitters(address allowlist) to thevmmoduleParamscheckCodeSubmissionPolicyin the ante handler: when policy is"permissioned",MsgAddPackageandMsgRunare rejected for any signer not on the allowlist — before typechecking runs, covering bothCheckTxandDeliverTx"permissionless"; existing chains and devnets are unaffectedpb3_gen.gowith fields 14/15 for the new params (codec parity maintained)TestAppHashCrossrealm38hash (intentional consensus-state change)gno.land/adr/prxxxx_code_submission_policy.mdChanges
gno.land/pkg/sdk/vm/params.go— newCodeSubmissionPolicytype + fields, validation,WillSetParamcasesgno.land/pkg/gnoland/app.go—checkCodeSubmissionPolicyfunction wired after session restrictionsgno.land/pkg/sdk/vm/pb3_gen.go— amino codec fields 14 (policy string) and 15 (submitters repeated address)gno.land/adr/prxxxx_code_submission_policy.md— ADRTest plan
go test ./gno.land/pkg/sdk/vm/...passesgo test ./gno.land/pkg/gnoland/...passescode_submission_policy=permissioned+ a submitter and verify unauthorizedMsgAddPackageis rejected