fix(gnovm): remove duplicated escaped-hash delete in DelObject#5899
Merged
Conversation
Collaborator
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
ec62b79 to
eaa133d
Compare
DelObject deleted the escaped object hash from the IAVL store twice, via two identical back-to-back blocks (introduced in gnolang#5415). The second delete is a no-op for state and gas-neutral (the cache store's write dedup refunds the repeated charge), so this is dead code and wasted node work only. No gas goldens change.
eaa133d to
f003f39
Compare
davd-gzl
approved these changes
Jul 3, 2026
thehowl
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultStore.DelObjectdeletes the escaped object hash from the IAVL store twice, via two identical back-to-back blocks (the duplicate was introduced in #5415). This removes the redundant second block.Impact
The second delete is a no-op for state, and gas-neutral: the cache store's per-key write dedup refunds the repeated charge, so this is dead code and wasted node work only. No gas goldens change.
Changed files
gnovm/pkg/gnolang/store.go— bug fix (dead-code removal), 5 lines deleted.Verification
go test ./gno.land/pkg/sdk/vm/ -run Gas✅go test ./gno.land/pkg/integration/ -run TestTestdata✅ (no golden changes)go test ./gnovm/pkg/gnolang/ -run Files -test.short✅🤖 Generated with Claude Code