Replace SixLabors.ImageSharp: 4.x requires a commercial license #181

Activity

1. 0Keith

   self-assigned this

   on Sep 27, 2026
2. 0Keith

   added

   dependenciesPull requests that update a dependency filePull requests that update a dependency file

   .NETPull requests that update .NET codePull requests that update .NET code

   on Sep 27, 2026
3. 0Keith commented on Sep 27, 2026

   

   0Keith

   on Sep 27, 2026

   CollaboratorAuthor

   More actions

   Migration plan: SixLabors → SkiaSharp

   Open decision: where the SkiaSharp code lives (Captain's call)

   • A. Keep all SkiaSharp code in Core/Imaging/ (recommended). One place holds every image operation: resize-to-fit, gallery thumbnail, icon load and resize, wallpaper annotation, PNG encoding with the JPEG fallback, and drawing the tray icons. No other file references SkiaSharp. This mirrors the existing Core/Platform/ rule. This issue exists because an imaging library leaked into eight files, so a future swap would then touch only this folder.
   • B. Replace ImageSharp in place in each file. The same eight files change, and SkiaSharp calls stay scattered the way ImageSharp's are today.

   Package

   • Add a direct reference to SkiaSharp at the version Avalonia 12.1.1 already resolves (3.119.4, MIT licensed). The native libraries already ship in both published binaries because Avalonia renders with Skia.
   • Remove SixLabors.ImageSharp and SixLabors.ImageSharp.Drawing from both project files, and remove the Dependabot ignore rule added in chore(deps): stop Dependabot proposing ImageSharp major versions #183.

   Changes per usage site

   File	Today	After
   SwitchWallpaper.cs	load, annotate with outlined title and timestamp, PNG encode then JPEG quality fallback over 16 MB	calls the imaging layer; the outline is still a stroke pass then a fill pass, width fontSize/12 with a 1px floor; the 16 MB fallback logic is unchanged
   DownloadWallpapers.cs	resize to fit the resolution cap, re-encode JPEG 95 or 8-bit RGB PNG	same behaviour through the imaging layer
   ViewModels/GalleryItem.cs	600px-wide PNG thumbnail	same
   App.axaml.cs	32px app icon, four 16px tray icons drawn as shapes	same shapes drawn on a Skia canvas
   Core/Platform/DesktopEntry.cs	resize the hicolor icon	same
   Core/BundledFonts.cs	bundled Cinzel collection, system font lookup	Skia typeface loaded from the bundled font stream, system fonts through Skia's font manager
   ViewModels/WallpaperConfigViewModel.cs	font picker lists system families	lists Skia's installed families; still never a hardcoded list
   Core/WallpaperNexusSettings.cs	empty font-family guard, comment names SixLabors	guard kept, comment updated

   Tests

   • The test helpers build their fixture images with SkiaSharp, and the dimension checks read images through SkiaSharp.
   • The font-picker test compares against Skia's installed families.
   • New tests for the imaging layer: resize-to-fit output size, thumbnail width, the JPEG fallback when the PNG exceeds the limit, and annotation that changes pixels only in the expected corner. Everything runs in memory, with no OS calls.

   Verification

   • Release build and the full test suite.
   • Run the app with --debug on the GNOME dev VM. Switch wallpaper with annotation on, then open current.png and look at the title, outline and position. Confirm the desktop shows it through gsettings. Screenshot the tray menu icons and check the hicolor icon file.
   • Gap: there is no Windows machine to run on, so on Windows only the published win-x64 build is verified, not how the app runs.

   Docs

   CLAUDE.md Dependencies and Wallpaper Processing sections, and the Core/Imaging/ folder in the structure tree if A is chosen.
4. 0Keith

   added a commit that references this issue on Sep 27, 2026

   refactor(imaging): replace ImageSharp with SkiaSharp in Core/Imaging (#…

   ...

   9b21b61
5. 0Keith

   closed this as completedin #191on Sep 27, 2026