Skip to content

Cleanup CMake configuration for external blocks runtime support #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Cleanup CMake configuration for external blocks runtime support #355

wants to merge 6 commits into from

Conversation

@hmelder
Copy link
Member

@hmelder hmelder commented Oct 20, 2025

This pull request addresses the following issues:

  • The check_symbol_exists check fails, when Block.h is located in the CMAKE_PREFIX_PATH.
  • Internal blocks runtime is always compiled, resulting in duplicate symbol errors on Windows and WebAssembly.
  • Internal blocks runtime test is always compiled and executed.
  • External symbols from the blocks runtime are incorrectly imported on Windows

hmelder added 2 commits October 9, 2025 04:40
@hmelder
remove unused CMake directory
d5d3211
@hmelder
Add FindBlocksRuntime.cmake from the libdispatch project
9d8fb81 
This is a slightly modified version of the file found in swift-corelibs-libdispatch. Notabily, the non-existent HINTS are removed.
@hmelder hmelder requested a review from davidchisnall October 20, 2025 10:43
@hmelder hmelder force-pushed the cmake-fix-include-dirs branch from f557cc1 to 6a18e54 Compare October 20, 2025 10:49
This was referenced Oct 20, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidchisnall davidchisnall Awaiting requested review from davidchisnall

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hmelder