Update touch bar and scrubber code #372
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredkiefer
approved these changes
Oct 13, 2025
| @@ -0,0 +1,402 @@ | |||
| /* Implementation of class GSTouchBarWindow | |||
There was a problem hiding this comment.
Is there intentionally just one star?
|
|
||
| @implementation GSTouchBarWindow | ||
|
|
||
| /* * Class methods */ |
There was a problem hiding this comment.
This looks strange. Remove the star or add a line break.
|
|
||
| - (void) dealloc | ||
| { | ||
| [_fallbackWindows release]; |
There was a problem hiding this comment.
Why don't you use the macro here?
| { | ||
| window = [[GSTouchBarWindow alloc] initWithTouchBar: touchBar]; | ||
| [_fallbackWindows setObject: window forKey: key]; | ||
| [window release]; // Retained by dictionary |
There was a problem hiding this comment.
Again, please use the macro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.