Ensure LogEntrySetField(s) affect value returned by LogEntry#48
Closed
nfcampos wants to merge 2 commits intogo-chi:masterfrom
Closed
Ensure LogEntrySetField(s) affect value returned by LogEntry#48nfcampos wants to merge 2 commits intogo-chi:masterfrom
nfcampos wants to merge 2 commits intogo-chi:masterfrom
Conversation
`LogEntry` returns the logger pointer stored on `RequestLoggerEntry`, therefore LogEntrySetField needs to update the value that pointer refers to, instead of replacing it with a new pointer
akira
approved these changes
Oct 1, 2024
Contributor
|
Closing since v3 was merged. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LogEntryreturns the logger pointer stored onRequestLoggerEntry, therefore LogEntrySetField needs to update the value that pointer refers to, instead of replacing it with a new pointer. Added a test that failed without this fix.