Refactor comment handling into tag map.#4
Open
hopesea wants to merge 7 commits intogo-flac:masterfrom
Open
Conversation
Member
|
Hi hopesea, Thanks for the submission and it really solved a lot of the problems that I know this package had but did not have energy to fix due to my own work schedule. However I am not in favor of changing this from a slice to a map, there are two drawbacks to this which I don't think making this compromise is worth it for a simple wrapper package on Vorbis tags:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process Vorbis comment as a map for cleaner handling of tags. Allow for setting (in addition to previous add) handling of tags. Case-insensitive handling of tag names.